3 ms·
Code reviews, aka opportunities for dickheads to demonstrate how clever they are. "Did you know you can replace that entire function with a regex?"
by geoffmunn 8y ago
Code reviews, aka opportunities for dickheads to demonstrate how clever they are.
"Did you know you can replace that entire function with a regex?"
- tristanperry 8y agoI think this comes down to team culture and morale. This certainly does happen in a team with a bad culture/morale, but IMO it's just a symptom of the wider issues. But yep, code reviews do make situations with bad morale worse IMO.
- closeparen 8y agoMediocre code review is a human linter; decent code review catches obvious bugs; good code review catches subtle bugs; great code review teaches you something. I’m always excited to learn (or teach) when there’s a better way to write something. Even if not adopted, the surrounding discussion is a boon to future readers. If people are giving crazy suggestions, or resenting good ones, something is seriously wrong with your team.