3 ms·
> I don’t think highly of myself as a developer but I find my coworkers extremely sloppy and it seems to me they focus more on narrow problems than the big pict
by aidenn0 8y ago
> I don’t think highly of myself as a developer but I find my coworkers extremely sloppy and it seems to me they focus more on narrow problems than the big picture.
Without knowing the full context I can't say who is right or wrong here. Sometimes sloppy code that focuses on narrow problems is the right solution! In some cases, good can be the enemy of good enough. From a business point of view, code should be just good enough to get people to throw money at you, and no better.
I'll be honest and say that writing the last paragraph left a bad taste in my mouth; it's clearly a bit of an exaggeration, but I put it down to make the point that it is obvious that there is some point at which effort spent working to make the code better is wasted effort, and carries opportunity costs that are detrimental to the goals of the project. Obviously the reverse is true as well.
Absent any other knowledge, I suspect the optimal point is somewhere between what you would like and what your colleagues would like.
For each specific gripe you have that you see happening regularly, consider: is this detrimental to the goals of the project, or is it something that is merely unpleasant for me to deal with. When doing this calculus, remember that short-term progress can be required for long-term survival (e.g. if you go bankrupt before shipping anything, it doesn't matter how good the would have been).
If the list of things that are not harmful to the projects survival but distasteful to you is particularly long, you'll probably want to find a new project to work on.
Finally a template for bringing up these concerns in some sort of team meeting (or with the team-lead if you have one, with a team of 6 you might):
1. I have a concern about [specific pattern X] I've seen in code reviews because it will impact our ability to achieve [project goal Y] due to [reason Z].
2. A solution that worked on my previous team was [solution S].
3. Do you think we could adapt [solution S] to work for this team?
The nice thing about this template is that nothing is labeled as "bad" but rather things are couched in terms of what are (hopefully) common goals. There is no implication that you are superior to others (as long as you aren't patronizing in your delivery). There is plenty of room for them to disagree. The main gate is item #1. If you and them almost always disagree at this point, then this is a bad team fit. If they agree on that point, then even if they hate your solution, you've started a conversation about how to fix the problem, which is probably more important that adopting the specific solution you had in mind.
Oh, how not to use this template (just in case it wasn't obvious):
"I have a concern that everybody except me is writing shitty code. On my previous team we solved this by actually caring about code quality, do you think we could adapt that to our current project?"
Which follows the template but misses the point completely...