4 ms·
Formalizing expectations is the best way to get everyone on board. My team relies on custom linting rules to act as that coding rules doc and builds the checks
by protonimitate 8y ago
Formalizing expectations is the best way to get everyone on board. My team relies on custom linting rules to act as that coding rules doc and builds the checks into the deployment pipeline so your build won't succeed if you have poorly formatted code. It doesn't catch everything, but it makes you more aware while writing code and gives a baseline minimum for standards.
Also, there is a way to provide constructive feedback without attacking the person behind the keyboard or phrasing it as 'you're wrong, make it right'.
The best reviewer on my team takes the time to point out where the 'big picture flaws' are, but phrases it in a way of 'this works, but here's why it won't work later on, and why you should consider fixing it now, just my 2c', rather than 'you're dumb if you think this is acceptable'.