4 ms·
I just took a new job and I think my coworker thinks this about me. Here's the thing though: I'm not sloppy, he just overcomplicated everything. Seriously, I'd
by seattle_spring 8y ago
I just took a new job and I think my coworker thinks this about me. Here's the thing though: I'm not sloppy, he just overcomplicated everything. Seriously, I'd have to be fucking telepathic to write a PR that passes whatever arbitrary level of ultra-complexity he'd expect.
Being "strict" in code reviews is not necessarily a good thing. It's great if you're strict with regard to stability and code standards, but it's not at all great when you reject everything because, "hey, this super specific module should be written because MAYBE ONE DAY in 20 years it could be maybe re-used, so you should make it ultra-generic and over complex."