3 ms·
It doesn't work though. The stuff that is made is often garbage performance wise, falls over a lot and ends up people spending hours trying to keep it running /
by LandR 8y ago
It doesn't work though. The stuff that is made is often garbage performance wise, falls over a lot and ends up people spending hours trying to keep it running / restarting it.
We also have no testing process, no code review process. I find out about stuff when I have to fix a bug in it. That is often the first time I will see something that is deployed to production.
Also deploy is basically the drev works on something, which like I said is often garbage with no thought put into it, then just copies it to a live server.
I then get told it's not working and can I have a look, see that it looks like it's been writen by someone that suffered blunt force trauma to the head before they started and die a little inside.
Every. Godamn. Time.
I need a new job.
An example:
A database update that was taking 9 minutes to insert a few thousand rows. Why? Because it was a nested foreach loop with a sql call in the middle...
Or when they had an array (in C#) but they didn't know how big it was going to have to be. There solution was to make it way bigger than it needed to be, by a lot, add to it. Then have a loop where they started at the end and resized the array by one item at a time until they had no more nulls... At least they left a comment in that saying someone needs to rewrite this as it was bad performance wise... I guess that's something.
- CydeWeys 8y agoGood christ, why would you use primitive arrays in C# like that?! How would someone not know about the List class? It sounds like suffering from premature optimization, and then completely failing at knowing how to do the optimization part.
- LandR 8y agoThere are still some devs today that have years of experience that avoid List<T> because they don't understand generics. Yes, honestly. Or even better (worse), we have a database table that stores the state things. State can be one of a small collection of states, e.g. Foo, bar, Quax. It's enumerable. How do we store it in the database table? as an nvarchar Id = 1, State="Set State to Foo" So any query was having to do a string parse to get the state out by grabbing the string after "Set State to " Which was killing the database as the table has millions of rows and is used all the time. I have so many examples like this.
- CydeWeys 8y agoThe last time I ran into something this bad was ten years and two jobs ago when, in front-end JS, someone needed a lookup map, but instead of just using a JS object, he implemented an array where the even entities represented keys and the odd entities represented values, and for lookup he used a for loop over the even indices of the array to iterate through keys until he found a match. Yes, it was terrible. He came from IBM too. I haven't run into anything that bad since; even my interns know a lot better. I'd suggest that if this is a routine problem for you, you might want to go find a team or job that has better programmers.
- angry_octet 8y agoI feel your pain. The worst part is that, when you push for some basic SE practices, the senior devs/researchera/PMs say (1) but we don't have the time to do planning/reviews/testing/mentoring, just look at the schedule, and (2) they don't want their own code to be subjected to review. I slid sideways away from that endless crunch / hero 10x coder / code solo project, but I need a proper new job too.