4 ms·
>June 25, 2018, https://github.com/donnelldebnam/CodeU-Spring-2018-29/pull/59 https://github.com/donnelldebnam/CodeU-Spring-2018-29/pull/5... “Thanks!!” A stra
by Arnavion 8y ago
>June 25, 2018, https://github.com/donnelldebnam/CodeU-Spring-2018-29/pull/59 https://github.com/donnelldebnam/CodeU-Spring-2018-29/pull/5... “Thanks!!”
A strange fix to equally strange code. In the old code `tags` wasn't used in the first place, and in the new code it's put inside a scope ensuring it definitely can't be used. Why not just delete it?
If it's being used just for side-effects in the `getAllHashtags()` call, why still bind it to a variable?
Edit: Also, it isn't consistent with the original code in that it prefixes the member access with `this.` whereas the old code didn't do that. If I were the bot's author I wouldn't consider this commit a particularly good example of the bot's capability...
- devoply 8y agoThe fixes as far as I can tell are pretty rudimentary, like if something is null and someone is trying to do something with it put an check for null around it. I would imagine if your used something like this consistently you code would become very much like a biological system -- a hack here a hack there... but hey it works.