4 ms·
This is not something I’d do on master, of course -- just on my own branch while working on stuff that will eventually become a single PR. I like to curate my
by iainmerrick 8y ago
This is not something I’d do on master, of course -- just on my own branch while working on stuff that will eventually become a single PR.
I like to curate my commit(s) as I go, so that the final PR is easy to understand.
- mlthoughts2018 8y agoOh, I see. Yes, that is a very standard workflow. I also commonly address PR change requests in isolated commits as well, and then link back in the PR review page with something like “fixed in <commit hash>”, so that reviewers can see isolated commit changes fixing itemized requests, and also so that no review comments ever go without some explicit reply, either demonstrating the fix or explain why to not do it or table it for later. I guess in this sense, these items don’t have much to do with whether the big conjunction of conditions necessary for TCR are satisfied or not.