3 ms·
If the branches are properly merged so that the dependency is represented in the git DAG, most good PR tools just handle this correctly: if you merge the depend
by WorldMaker 8y ago
If the branches are properly merged so that the dependency is represented in the git DAG, most good PR tools just handle this correctly: if you merge the dependent PR first the dependee updates to show the commits as already merged and "simplify" their diff views appropriately; if you merge the dependee PR first, the dependent PR simply gets marked as completed/merged for you.
I find it is still useful to include helpful hints like "this PR includes all of PR #1234, if you prefer to review a piece at a time", but that's for the reviewers' sake, not the tools'.
- dom96 8y agoYes, that's nice. But the problem is that these are still shown as separate PRs, GitHub for example doesn't tie these together unlike Phabricator.
- WorldMaker 8y agoGitHub has enough information that it could surface that better. It's a useful feature request.