4 ms·

You do what you should have done in the first place and locate specific problems. If the code is too clever for you, ask them to refactor in a simpler way rath

• 08-15 8y ago
  Well, you ask for improvement and reject. You have to, because you don't want to accept it. That pisses the submitter off. What now? A possible alternative is to do what Pieter Hintjens recommended: Accept everything, wait for the community to clean it up. Somebody might outright revert the bad patch... you accept that reversion patch, too, because you don't judge, you accept everything. This approach supposedly worked well for Pieter, but 0MQ isn't nearly as big or as visible as Linux.
  • BeetleB 8y ago
    >Well, you ask for improvement and reject. You have to, because you don't want to accept it. That pisses the submitter off. What now? The goal of better communication (in this case) is not to be the offensive asshole. It is not to ensure the other person isn't pissed off. I've pointed it out in earlier threads, but do try to read some good books on communication. While they do talk about phrases that lead to defensive behavior and how to avoid them, the focus is always on ensuring your perspective gets out, and i a way that is most likely to be heard. As one book said "Do not make a metric how upset the other person becomes. That is giving too much control to the other party, and you have limited control over their behavior".