4 ms·
This is such an underrated comment. I love this style of code reviews and it's the one I've experienced best discussions with. It goes in line with assuming th
by kangax 8y ago
This is such an underrated comment.
I love this style of code reviews and it's the one I've experienced best discussions with. It goes in line with assuming that you, as a reviewer, don't know what the intentions/rationale are rather than blindly dictating your solution. A lot of times the reviewer that says "this is wrong" is then explained to why it was done a certain way and is the one proven wrong. Questioning yourself as a reviewer is always a good idea. Asking questions gives feedback without coming off aggressive/judgemental/patronizing.