4 ms·
If someone reviews your code, it will sting when they point out silly mistakes. The insults that the kernel devs fling about just aren't needed to drive home th
by kryptiskt 8y ago
If someone reviews your code, it will sting when they point out silly mistakes. The insults that the kernel devs fling about just aren't needed to drive home the point.
- branchless 8y agoAgreed. What can be worse than having a comment to the effect of "if x is -1, which is feasible, this will cause undefined behaviour resulting in a crash". For most people this stings more than enough.
- crdoconnor 8y agoHe reserved the insults for bad design decisions defended by senior committers. It's not like he threw out insults to anybody who ever made a mistake.