4 ms·
But react-dates has moment as dependency, so…
by ggregoire 8y ago
But react-dates has moment as dependency, so…
- BigJono 8y agoWelcome to the wonderful world of code re-use. Hey, at least we're not re-inventing the wheel.
- nkozyra 8y agoWe're reimporting the wheel (which, by the way, also has moment.js as a dependency)
- pnevares 8y agohttps://github.com/airbnb/react-dates/blob/master/package.json#L95 https://github.com/airbnb/react-dates/blob/master/package.js... A devDependency is not the same as a dependency.
- scottlecrab 8y agoIt's a dev dependency because they use it in unit tests but it's also a peer dependency, meaning that if you want to use the library you need to include moment.
- pnevares 8y agoThat's my error, thanks for the correction.