3 ms·
Sorry, not sure if I read correctly, but are you advocating against code reviews before committing code?
by ryandrake 8y ago
Sorry, not sure if I read correctly, but are you advocating against code reviews before committing code?
- JoeAltmaier 8y agoI'm advocating against self-appointed police setting themselves up as arbiters of style and technique, who delay projects by weeks and multiply the effort required to pass their arbitrary notions of how a pointer should be compared to null or whatever. Its insulting, pointless and aggravating, especially when you spend Labor Day weekend cranking to get a feature ready for a demo, but can't check it in Monday because so-and-so doesn't like some style issue.
- ryandrake 8y agoSounds like valid criticism of a particular review process or reviewer, not reviews as a general gate to pushing code. I’ve worked at places without mandatory code review and the code in those places is consistently awful.
- JoeAltmaier 8y agoI've never experienced anything else along those lines, so your mileage may vary of course. But once a company falls into this trap, its not something the new guy can fix.