3 ms·
Yes. When you have a style guide - test for it, if the test fails, then fail the style linter job and don't allow the change to be accepted. It's failed to me
by kiallmacinnes 8y ago
Yes.
When you have a style guide - test for it, if the test fails, then fail the style linter job and don't allow the change to be accepted.
It's failed to meet your acceptable code criteria after all.
If you find you are making your code unreadable just to pass, then your style guide is wrong. That needs fixing, not the CI job.
If you find an urgent "this needs to merge, style rules be dammed" change, allow your senior team members to overrule the style CI job and merge it anyway.