3 ms·
> Terrible naming, e.g. 'vis' -> reading the function it means toggle visibility, so it should be called 'toggleVisibility' But it doesn't toggle visibility. I
by tzs 8y ago
> Terrible naming, e.g. 'vis' -> reading the function it means toggle visibility, so it should be called 'toggleVisibility'
But it doesn't toggle visibility. It sets visibility.
- adamjc 8y agoYeah, you're right, I misread the code. It should be called 'setVisibility' then. A problem that wouldn't exist if it was named correctly in the first place ;)