3 ms·
It works... every criticism beyond that is just an argument about taste, although personally I think it's unnecessarily terse. I've written uglier code and got
by krapp 8y ago
It works... every criticism beyond that is just an argument about taste, although personally I think it's unnecessarily terse.
I've written uglier code and gotten paid for it. ¯\_(ツ)_/¯
- jenscow 8y agoAnd no doubt I've written single methods/functions that where uglier.
- DanHulton 8y agoNot necessarily. Sure, all code has to work, but unless you're going to ship a product and then never, ever return to it, it has to be maintainable as well. There are a few arguments in this thread about poor maintainability of this code, when coupled to the HTML it affects (which always must be considered, otherwise this code is pointless), and I tend to agree with them. Personally, I wouldn't mind some less terse names and some more semantic groupings of HTML nodes. Thankfully, it is simple. I'm pretty sure doing that would be the task of an afternoon, though I would definitely want to accomplish that before trying to change anything else on the page.
- krapp 8y ago>but unless you're going to ship a product and then never, ever return to it, it has to be maintainable as well. This is Hacker News... there's a good chance it will go more or less unchanged for a while.