3 ms·

The Visual Studio Marketplace is also down https://marketplace.visualstudio.com/ https://marketplace.visualstudio.com/.

whoisjuan 8y ago
Just today I was having issues with the Prettier extension in VS Code, and I uninstalled it to see if that would fix it (I read that usually fixes the issues I was having). Then I realized that I couldn't install it again because VS Marketplace was down. This was like 8 hours ago and still no signs of recovery. Of course, all my builds are failing because of some stupid formatting issue that Prettier usually would solve, so yeah..thanks MSFT.
- TeMPOraL 8y ago
  > Of course, all my builds are failing because of some stupid formatting issue that Prettier usually would solve, so yeah..thanks MSFT. Is failing builds due to formatting issues really a sound setup?
  - amaccuish 8y ago
    I assume their build system checks for formatting and will raise an error if it doesn't conform. And this person would use the VS Code extension to auto-conform their code.
    - TeMPOraL 8y ago
      I'm questioning the soundness of such setup in general, and especially if it means that losing connection to a third-party prettifier makes you unable to work on your own codebase.
      - Vinnl 8y ago
        Hmm, the alternatives are not enforcing a similar code style, or enforcing it earlier on (e.g. on commit). I can understand why they would not want the former, and the latter is more annoying when experimenting, i.e. when code style does not matter that much yet. Thus, in CI sounds like the right choice.
        w0m 8y ago
        I'd go for precommit hook or similar, but not a huge deal.
      - kiallmacinnes 8y ago
        Their not unable to work, they just don't have a "format this according to the rules our codebase has set out" button. They can also just format their code according to the rules by hand..
  - kiallmacinnes 8y ago
    Yes. When you have a style guide - test for it, if the test fails, then fail the style linter job and don't allow the change to be accepted. It's failed to meet your acceptable code criteria after all. If you find you are making your code unreadable just to pass, then your style guide is wrong. That needs fixing, not the CI job. If you find an urgent "this needs to merge, style rules be dammed" change, allow your senior team members to overrule the style CI job and merge it anyway.
  - whoisjuan 8y ago
    I can add an ignore formatting line, but then people would ask why I did that. We have a styleguide to increase readability and make code-reviews easier. Is it a sound setup? I personally think it is. It promotes good standards and can sometimes even help catch some issues related to structure and code flow.
tananaev 8y ago
This is very inconvenient. I'm not able to download an extension that I need to work on a project.
- Memosyne 8y ago
  It's back online again!

Just today I was having issues with the Prettier extension in VS Code, and I uninstalled it to see if that would fix it (I read that usually fixes the issues I was having). Then I realized that I couldn't install it again because VS Marketplace was down. This was like 8 hours ago and still no signs of recovery. Of course, all my builds are failing because of some stupid formatting issue that Prettier usually would solve, so yeah..thanks MSFT.

TeMPOraL 8y ago
> Of course, all my builds are failing because of some stupid formatting issue that Prettier usually would solve, so yeah..thanks MSFT. Is failing builds due to formatting issues really a sound setup?
- amaccuish 8y ago
  I assume their build system checks for formatting and will raise an error if it doesn't conform. And this person would use the VS Code extension to auto-conform their code.
  - TeMPOraL 8y ago
    I'm questioning the soundness of such setup in general, and especially if it means that losing connection to a third-party prettifier makes you unable to work on your own codebase.
    - Vinnl 8y ago
      Hmm, the alternatives are not enforcing a similar code style, or enforcing it earlier on (e.g. on commit). I can understand why they would not want the former, and the latter is more annoying when experimenting, i.e. when code style does not matter that much yet. Thus, in CI sounds like the right choice.
      - w0m 8y ago
        I'd go for precommit hook or similar, but not a huge deal.
    - kiallmacinnes 8y ago
      Their not unable to work, they just don't have a "format this according to the rules our codebase has set out" button. They can also just format their code according to the rules by hand..
- kiallmacinnes 8y ago
  Yes. When you have a style guide - test for it, if the test fails, then fail the style linter job and don't allow the change to be accepted. It's failed to meet your acceptable code criteria after all. If you find you are making your code unreadable just to pass, then your style guide is wrong. That needs fixing, not the CI job. If you find an urgent "this needs to merge, style rules be dammed" change, allow your senior team members to overrule the style CI job and merge it anyway.
- whoisjuan 8y ago
  I can add an ignore formatting line, but then people would ask why I did that. We have a styleguide to increase readability and make code-reviews easier. Is it a sound setup? I personally think it is. It promotes good standards and can sometimes even help catch some issues related to structure and code flow.

tananaev 8y ago

This is very inconvenient. I'm not able to download an extension that I need to work on a project.

Memosyne 8y ago
It's back online again!