3 ms·
So instead of printk("subtotals: a %d, b %d, c %d, total %d\n", a,b,c,a+b+c); you have printk("subtotals: a " COUNTER_T_FORMAT_SPECIFIER ", b " COUNTER_T_FOR
by gjm11 16y ago
So instead of
printk("subtotals: a %d, b %d, c %d, total %d\n", a,b,c,a+b+c);
you have
printk("subtotals: a " COUNTER_T_FORMAT_SPECIFIER ", b " COUNTER_T_FORMAT_SPECIFIER ", c " COUNTER_T_FORMAT_SPECIFIER ", total " COUNTER_T_FORMAT_SPECIFIER "\n", a,b,c,a+b+c);
and soon you (1) can't read your code at all because 60% of it is shouty stuff in your calls to printk and (2) even the printk calls are awkward to read because your eyes have to skip over all the shouty stuff to work out what the output's actually going to look like.
(Perhaps that was your point, in which case I apologize for thinking it needed spelling out more explicitly.)
- praptak 16y agoI was trying to be sarcastic.
- silentbicycle 16y agoIf you're going to be sarcastic, be so heavy-handed about it that you could sell it as a Methodology later. :) Otherwise, some people will take it at face value.