The thing about this is that people are bad at objectively analyzing contributions, especially their own. Some aspects of value to an employer/manager include y

The thing about this is that people are bad at objectively analyzing contributions, especially their own. Some aspects of value to an employer/manager include your regular work output quantity and quality, ability to learn new skills quickly (thus being dependable in unexpected situations), willingness to jump in to new challenges, mentoring other team members, etc. People often overlook these factors in others and say "I do the same work as them, or more!" and get upset about different compensation. I mean, certainly sometimes there is value in sharing this information, but there are also plenty of situations where it causes discord more than it helps the people involved, so I don't know that "discuss your salary!" is universally good advice.