4 ms·
Some suggestions: 1. Add rel="noreferrer" to the links you inject. 2. I don't think nested anchors are valid HTML. Try injecting your links after the username
by mike-cardwell 8y ago
Some suggestions:
1. Add rel="noreferrer" to the links you inject.
2. I don't think nested anchors are valid HTML. Try injecting your links after the username link, not inside it. And the underline between each icon on hover (in Firefox on HN pages at least) looks horrible.
3. All those icons look messy. Why not collapse into a single keybase icon which maybe opens a tooltip with more details when you click on it?
- dschep 8y ago1. definitely! thanks for the pointer 2. yeah. I should do that. 3. Yup. Already on my roadmap, just makes things a bit more complicated. Edit: 1 & 2 done in v2.2
- CiPHPerCoder 8y agoCan I suggest rel="noreferrer noopener"? https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/ https://www.jitbit.com/alexblog/256-targetblank---the-most-u...