5 ms·
> Well that they fail and that they take minutes to run isn't a bad thing; what is bad is that broken things end up on master. You don't understand; they are
by AllegedAlec 8y ago
> Well that they fail and that they take minutes to run isn't a bad thing; what is bad is that broken things end up on master.
You don't understand; they are continually broken on master.
Furthermore, you assume that we only commit to master after reviews etc have been done. This isn't the case. Commits, even intermittent commits, are pushed to master, and reviewed from there.
- pc86 8y ago> Commits, even intermittent commits, are pushed to master, and reviewed from there. I think most people would agree that's an objectively wrong way to do it.
- AllegedAlec 8y agoAgreed. I've been saying for a long time we should do it differently, but so far I've had no success.
- sopooneo 8y agoYou have to make the people love you. Then they will follow your good advice joyfully. In fact they'll follow your bad advice just as much, so be careful you don't get promoted to VP.