3 ms·
I guess so. One of the LWN comments mentions a Microsoft function memcpy_s defined as: memcpy_s (void *dest, size_t destSize, const void *src, size_t coun
by rwmj 8y ago
I guess so. One of the LWN comments mentions a Microsoft function memcpy_s defined as:
memcpy_s (void *dest, size_t destSize, const void *src, size_t count);
which is effectively equivalent to your memcpy_oobp function.
However the Microsoft function also returns an error code which must be checked (because count might be larger than destSize), thus providing another way for the programmer to screw up. I'm not sure if this is better or worse than just copying the min() as in your second example. It probably depends on the situation.
- lomnakkus 8y agoUsing min() seems like it could be incredibly dangerous as an "implicit" behavior, not to mention surprising. I'd wager it'd be much better to just specify that abort() gets called in the "overflow" case. (Given that overflow is basically never what you want anyway.) Yeah, it'll crash but at least it won't be suprising/undefined behavior.
- rwmj 8y agoFor extra fun, the Microsoft implementation of memcpy_s returns an error instead of crashing if either of the pointers is NULL (thankfully doesn't apply if the copy size is 0). There's a reason I don't like writing software for Windows ...