3 ms·
If this[0] is indeed the inadvertent commit we’re talking about...how is that code? It’s three URLs in a JSON file, one of which even contains the string “publi
by scolby33 8y ago
If this[0] is indeed the inadvertent commit we’re talking about...how is that code? It’s three URLs in a JSON file, one of which even contains the string “public”!
There’s no proprietary algorithm being described and I’m guessing that those URLs respond with 200 OK without any authentication of where the request is coming from, which says to me the host thinks it’s okay to send me that data. (On mobile or I would check.)
Would it still be a problem if it were forked and the JSON key names were changed or some other alternative method of configuring the URLs were used?
I would understand if the entire source file for interacting with the extension gallery were taken here, but just a config setting?! That says to me that I couldn’t write my own web browser with the default homepage set to Google without permission...
[0] https://github.com/Microsoft/vscode/commit/f1d0c1d88417f85ec66fa5629beca64ef71ac8b8#diff-3261b6aa3ae37f4f5a9faa60fb4a6845https://github.com/Microsoft/vscode/commit/f1d0c1d88417f85ec66fa5629beca64ef71ac8b8#diff-3261b6aa3ae37f4f5a9faa60fb4a6845 https://github.com/Microsoft/vscode/commit/f1d0c1d88417f85ec...