4 ms·

an extension I'd welcome for GitHub code reviews, is one tracking the review progress, e.g. allowing to flag on/off which files have been reviewed and which not

by dewiz 8y ago

piotrkaminski 8y ago
Then you might want to check out https://reviewable.io https://reviewable.io -- not an extension but does integrate with GitHub pretty nicely. (Disclaimer: I'm the founder.)
- dewiz 8y ago
  thanks for reminding me about this, I tried it a while back but eventually abandoned it, because of complex UI (lack of file tree on the side; the file matrix at the top doesn't make it easier to keep status; many buttons don't have a onmouseover tip so it's not clear what they, e.g. if the cause some state change; UI very different from GitHub leading to extra friction with team members) and the noise it generates in GitHub, for users who uses just GitHub
  - piotrkaminski 8y ago
    Yeah, fair enough. I want to move the file matrix into a sidebar file tree instead (along with the rest of the toolbar) but I'm blocking on some infrastructure work. I've been resisting tooltips on hover for the longest time but I'm capitulating on that as well -- for now, hitting F1 or H anywhere will bring up the help, but hover tooltips are coming. As for GitHub integration, I agree it's not ideal but it's the best their slightly brain-dead review API will allow. Getting the whole team to adopt the tool is much better, but is obviously quite a bit harder. Though that's probably why I'm seeing a lot more success in the enterprise space, where top-down diktats are par for the course.
    - dewiz 8y ago
      looking forward to see those changes, particularly on the sidebar, glad to see development is ongoing :-) About keeping state, I've always wondered if it would be possible to store state via git commits, e.g. via a special branch ".state/reviewable.io" or even another repo - is that doable, assuming the browser would use my identity to post status updates?
      - piotrkaminski 8y ago
        Development is definitely ongoing! The high-level changelog is at https://changelog.reviewable.io/ https://changelog.reviewable.io/ and you can get more granular updates via https://groups.google.com/forum/#!forum/reviewable-enterprise-announce https://groups.google.com/forum/#!forum/reviewable-enterpris... (though these releases usually go out a few weeks after the respective changes hit reviewable.io). Not sure what you mean about putting state in the repo. It's possible of course since you can stuff anything in there, but what would be the advantage? It wouldn't integrate with GitHub any better and it would throw away the real-time updates, queries, etc., available thanks to Firebase.
alexmdodge 8y ago
Something I have in the pipeline. I hope to add a feature which lets you toggle which items have been reviewed which would show up in the explorer.

an extension I'd welcome for GitHub code reviews, is one tracking the review progress, e.g. allowing to flag on/off which files have been reviewed and which not

by dewiz 8y ago

an extension I'd welcome for GitHub code reviews, is one tracking the review progress, e.g. allowing to flag on/off which files have been reviewed and which not

piotrkaminski 8y ago

Then you might want to check out https://reviewable.io https://reviewable.io -- not an extension but does integrate with GitHub pretty nicely. (Disclaimer: I'm the founder.)

dewiz 8y ago
thanks for reminding me about this, I tried it a while back but eventually abandoned it, because of complex UI (lack of file tree on the side; the file matrix at the top doesn't make it easier to keep status; many buttons don't have a onmouseover tip so it's not clear what they, e.g. if the cause some state change; UI very different from GitHub leading to extra friction with team members) and the noise it generates in GitHub, for users who uses just GitHub
- piotrkaminski 8y ago
  Yeah, fair enough. I want to move the file matrix into a sidebar file tree instead (along with the rest of the toolbar) but I'm blocking on some infrastructure work. I've been resisting tooltips on hover for the longest time but I'm capitulating on that as well -- for now, hitting F1 or H anywhere will bring up the help, but hover tooltips are coming. As for GitHub integration, I agree it's not ideal but it's the best their slightly brain-dead review API will allow. Getting the whole team to adopt the tool is much better, but is obviously quite a bit harder. Though that's probably why I'm seeing a lot more success in the enterprise space, where top-down diktats are par for the course.
  - dewiz 8y ago
    looking forward to see those changes, particularly on the sidebar, glad to see development is ongoing :-) About keeping state, I've always wondered if it would be possible to store state via git commits, e.g. via a special branch ".state/reviewable.io" or even another repo - is that doable, assuming the browser would use my identity to post status updates?
    - piotrkaminski 8y ago
      Development is definitely ongoing! The high-level changelog is at https://changelog.reviewable.io/ https://changelog.reviewable.io/ and you can get more granular updates via https://groups.google.com/forum/#!forum/reviewable-enterprise-announce https://groups.google.com/forum/#!forum/reviewable-enterpris... (though these releases usually go out a few weeks after the respective changes hit reviewable.io). Not sure what you mean about putting state in the repo. It's possible of course since you can stuff anything in there, but what would be the advantage? It wouldn't integrate with GitHub any better and it would throw away the real-time updates, queries, etc., available thanks to Firebase.

alexmdodge 8y ago

Something I have in the pipeline. I hope to add a feature which lets you toggle which items have been reviewed which would show up in the explorer.