2 ms·
What I'm describing is not a committee review any more than having Linus Torvalds review Linux kernel changes or Ben Pfaff review Open vSwitch changes. I can wr
by hodgesrm 8y ago
What I'm describing is not a committee review any more than having Linus Torvalds review Linux kernel changes or Ben Pfaff review Open vSwitch changes. I can write code just fine myself, but it's more effective to focus on making others productive because the whole project gets more work done that way.
Module decomposition is usually something I try to pick off in design, but when accepting pull requests from outside it's a critical consideration. We're not blocking creativity but trying to ensure that the code base not only remains high quality and that the design morphs appropriately over time as we meet new requirements. By making this a review point you can help create a culture where engineers think about it before submitting. That in turn makes it easier to justify dates to managers.