3 ms·
It actually could cause bigger problems than that. Most Go projects I've seen have CI runs that check whether 'gofmt' complains -- and fail builds if they do.
by cyphar 8y ago
It actually could cause bigger problems than that. Most Go projects I've seen have CI runs that check whether 'gofmt' complains -- and fail builds if they do.
Ultimately though I don't really care all that much. Everyone will fix it in a few commands, and everything will be green again.
- iainmerrick 8y agoI care if it makes it harder to browse version history and see which changes were made when, and why.
- cyphar 8y agoI don't think it would make it much harder if people just do all of the 'gofmt' changes in a single commit. After all, it's not like your entire codebase consists of such edge-cases, and if you hit a 'git blame' where the commit is a format change you can always just do 'git blame $THE_FORMATTING_REVISION^ $file'. I have to do this all the time when 'git blame -wM' doesn't give me what I want when looking at kernel changes.