My suggestion is to study the works of great photographers . A lot. BW: Ansel Adams, Edward Weston, Brett Weston, John Sexton,... Color: Ernst Haas, Harry Gruya

My suggestion is to study the works of great photographers . A lot. BW: Ansel Adams, Edward Weston, Brett Weston, John Sexton,... Color: Ernst Haas, Harry Gruyaert, Saul Leiter, William Eggleston,... Also study non-photographic books as well. I'm mostly interested in shapes and patterns, that's why I read architecture books as well. BTW, for this learning purpose, I made a decision to only shoot film (mostly 35mm, sometimes medium format). I usually have the Nikon F2 and Minolta spotmeter ready in my bag. Whenever I feel bored at work, I grab my camera and wander around, looking for anything interesting. By interesting, I mean anything. It doesn't have to be socially profound. It doesn't have to be 'decisive' ala Henri Carier-Bresson. It doesn't have to be dramatic like golden hour scene. Sometimes certain patterns in the window or a small crack in the well can be interesting too. You just need to see them carefully. If I'm shooting 35mm, 10 out of 36 frames is good enough. Or if I'm shooting medium format, perhaps 5 or 6 out of 12. Never immediately throw your bad photos. See if you can notice any mistakes/improvement possibilities.