5 ms·

How did you get that past code review?

• thom 8y ago
  It's cute that you think every company, even the kind that did brochureware sites for brands more than 10 years ago, does code review.
  • ada1981 8y ago
    It’s cute that you think it’s cute.
  • amingilani 8y ago
    I downvoted you because you were condescending while providing an otherwise relevant piece of information.
    • pc86 8y ago
      > Please respond to the strongest plausible interpretation of what someone says, not a weaker one that's easier to criticize. Assume good faith. > Please don't comment about the voting on comments. It never does any good, and it makes boring reading. https://news.ycombinator.com/newsguidelines.html https://news.ycombinator.com/newsguidelines.html
  • svnsets 8y ago
    Yeah there are plenty of companies that don't do code reviews still to this day. I worked for an ad agency for a bit and we were still using SVN (afaik they are still using SVN for many projects today). Everyone would just push code straight to trunk with no review process. I created a cool little easer egg where if you clicked in the bottom left corner of the browser window and dragged in a circle, the site would flip upside down. A coworker and I also photoshopped some of the client's imagery that was used on the site and hosted it on another domain. If you typed a variation of the Konami code while on the site, the images would be replaced with our meme-ified versions of their imagery. Even if we had a code review process, none of my coworkers would have even noticed that little bit of extra code in the mess of jQuery spaghetti that was their codebase.