3 ms·
Author here. I've talked to a nginx product manager and he's told me changes that are specific to one customer are unlikely to be accepted. Also in our implem
by khc 8y ago
Author here.
I've talked to a nginx product manager and he's told me changes that are specific to one customer are unlikely to be accepted.
Also in our implementation we took some shortcuts so it may not be suitable for upstream as is anyway
- LinuxBender 8y agoUnderstood. Perhaps you could make your improvements modular in some cases so that people can toggle them on, either as nginx modules, or compile flags in nginx core?
- khc 8y agoIn this case it's not possible to implement as nginx modules, but we are looking into releasing the patch as is.
- LinuxBender 8y agoVery nice! Thankyou for the improvements that your team is making.
- devwastaken 8y agoIt would be really great for some public projects if your internal modifications and updates to nginx were a public repo. That repo could be compiled and packaged for use of open source projects that benefit from those modifications. I say this because I've seen multiple patches from cloudflare around, but it's very difficult for 1 person to go through all of that, know what version of nginx it's for, and modify the patch for newer versions of NginX like security updates. If you modify nginx internally I don't doubt there's lots of various changes and improvements over time that don't get organized or published publicly. I think it'd be great if more companies released their own 'opinionated' versions that update with their infrastructure. Like if I wanted to host a OpenStreetMaps tiling server hypothetically using some features cloudflare has in their nginx builds. Makes it easy for white-hats to test, too. IIRC I've been intersted in HPACK for small http responses where the headers are larger than the body, but if I wanted to use the HPACK patch I have to re-impliment it every time an update comes out that modifies the file.
- bussetta 8y agolooking forward to it!
- thezilch 8y agoAny chance we can expect the patches to be applied to the nginx that ships with OpenResty? ;)
- always_good 8y agoI can't help but roll my eyes at these "hello, open source steward of the labor of others, checking in!" posts. Comes off as straight virtue-signaling.
- LinuxBender 8y agoI ask because I have had many challenges with nginx bugs and improvements. Maxim and I have fundamental disagreements about many things. Anything Cloudflare can do to make improvements upstream are appreciated.
- mp3geek 8y agoSubmit them to your own github repo?
- ksec 8y agoI see. I am wondering if you ever had a look at H20, which I think is being used by Fastly.