4 ms·
We have a reasonable way of dealing with this - bugs found in code reviews MUST be fixed - coding style violations MUST be fixed (ideally all of these are cau
by reggieband 8y ago
We have a reasonable way of dealing with this
- bugs found in code reviews MUST be fixed
- coding style violations MUST be fixed (ideally all of these are caught by lint but not all are)
- everything else is treated as optional
Some code review tools even provide the ability to specify required vs. optional feedback. We now use github reviews which doesn't have this feature so we usually just add OPTIONAL to any review comment that isn't in the MUST fix category.
Occasionally a reviewer and reviewee will get into discussion/disagreement over the approach a particular code change. In those cases if it isn't clearly a bug or a style violation we err on the side of the reviewee.