3 ms·
Yes. There shouldn't be any reviewee except the code itself. But this is hard to get right. One of the questions I try to ask myself with any comment I write a
by lolc 8y ago
Yes. There shouldn't be any reviewee except the code itself. But this is hard to get right.
One of the questions I try to ask myself with any comment I write as a reviewer: "Would I accept this comment?".
- jelambs 8y agoAuthor here, I think that’s a great approach. We surface our guidelines for every PR by including a link to them in the description template. This acts as a reminder for people to be thoughtful about their review. I think the fact that our guidelines were based on input from the most senior to the most junior engineers says a lot about how much we value everyone’s opinions and perspective, not just the loudest voices.