4 ms·

http://www.emulator101.com/logical-operations.html http://www.emulator101.com/logical-operations.html /* Example 2: turn on one LED on the control panel */

http://www.emulator101.com/logical-operations.html http://www.emulator101.com/logical-operations.html /* Example 2: turn on one LED on the control panel */ char * LED_pointer = (char *) 0x2089; char led = *LED_pointer; led = led | 0x40; //set LED controlled by bit 6 *LED_pointer = led; Really?

deleted 8y ago
[deleted]
teraflop 8y ago
What's wrong with that? If you're writing code for pedagogical purposes, it doesn't necessarily need to be as concise as possible.
- monocasa 8y ago
  In fact, in my firmware writing style, I tend to separate MMIO accesses from mutation to make it clear when those bus accesses occur.
- simias 8y ago
  I know some people who object to one-line read-modify-write of hardware registers, the idea being that glancing at the code the non-atomicity of the operation might be lost. I also generally don't use raw volatile pointers directly when dealing with hardware registers, too easy to forget a "volatile" somewhere and have the code behave erratically. I always use tiny read32/write32 wrappers instead.
  - kstenerud 8y ago
    Absolutely. Modern compilers are trivially able to inline such operations, so there's no reason not to make your intentions and separation of operations crystal clear. After all, you're going to read the code a lot more often than you'll write it.
  - planteen 8y ago
    Yes and read/write barriers are also sometimes necessary, to prevent re-ordering by the compiler and processor.
  - sigjuice 8y ago
    Yes, wrappers are the way to go. e.g. Linux kernel
  - monocasa 8y ago
    You have to be careful though in some cases. For instance, if you read two MMIO registers in a one liner, there's no way to guarantee the ordering between them.
CobrastanJorji 8y ago
Yes really. It's example code written for the sole purpose of being read by people for educational purposes. As long as you understand the basics of pointers, it's really easy to read. Why are you mad at it?

deleted 8y ago

[deleted]

teraflop 8y ago

What's wrong with that? If you're writing code for pedagogical purposes, it doesn't necessarily need to be as concise as possible.

monocasa 8y ago
In fact, in my firmware writing style, I tend to separate MMIO accesses from mutation to make it clear when those bus accesses occur.
simias 8y ago
I know some people who object to one-line read-modify-write of hardware registers, the idea being that glancing at the code the non-atomicity of the operation might be lost. I also generally don't use raw volatile pointers directly when dealing with hardware registers, too easy to forget a "volatile" somewhere and have the code behave erratically. I always use tiny read32/write32 wrappers instead.
- kstenerud 8y ago
  Absolutely. Modern compilers are trivially able to inline such operations, so there's no reason not to make your intentions and separation of operations crystal clear. After all, you're going to read the code a lot more often than you'll write it.
- planteen 8y ago
  Yes and read/write barriers are also sometimes necessary, to prevent re-ordering by the compiler and processor.
- sigjuice 8y ago
  Yes, wrappers are the way to go. e.g. Linux kernel
- monocasa 8y ago
  You have to be careful though in some cases. For instance, if you read two MMIO registers in a one liner, there's no way to guarantee the ordering between them.

CobrastanJorji 8y ago

Yes really. It's example code written for the sole purpose of being read by people for educational purposes. As long as you understand the basics of pointers, it's really easy to read. Why are you mad at it?