3 ms·
I think it’s really shortsighted to hardcode them statically into constants. You’d have to build a completely new binary should the requirements someday change!
by Sharlin 8y ago
I think it’s really shortsighted to hardcode them statically into constants. You’d have to build a completely new binary should the requirements someday change! Obviously they belong behind a configuration interface, an instance of which can then be dependency injected to places that need them. In this way you can easily supply them from whatever source you like, such as a properties file, XML document, a database or even a web service.
As it is now, 2/10 would not pass review.
- oweiler 8y agoSounds like Spring ConfigurationProperties https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html#boot-features-external-config-typesafe-configuration-properties https://docs.spring.io/spring-boot/docs/current/reference/ht...
- Sharlin 8y agoI'm utterly unsurprised.