5 ms·
I'm gonna need a write up. I've been looking at the code for 10 or 15 minutes and I still haven't found "fizz", "buzz", or the number 100 anywhere in the code.
by jedimastert 8y ago
I'm gonna need a write up. I've been looking at the code for 10 or 15 minutes and I still haven't found "fizz", "buzz", or the number 100 anywhere in the code. It's amazing.
- Aardwolf 8y agoFound it!! https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpriseEdition/blob/f98ec95911ed319809e915754c872f90dc194408/src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/Constants.java https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpris...
- conistonwater 8y agoI have no idea either, but those are "constants", and so it is only logical that they belong in com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl.Constants (https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpriseEdition/blob/f98ec95911ed319809e915754c872f90dc194408/src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/Constants.java https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpris...).
- Sharlin 8y agoI think it’s really shortsighted to hardcode them statically into constants. You’d have to build a completely new binary should the requirements someday change! Obviously they belong behind a configuration interface, an instance of which can then be dependency injected to places that need them. In this way you can easily supply them from whatever source you like, such as a properties file, XML document, a database or even a web service. As it is now, 2/10 would not pass review.
- oweiler 8y agoSounds like Spring ConfigurationProperties https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html#boot-features-external-config-typesafe-configuration-properties https://docs.spring.io/spring-boot/docs/current/reference/ht...
- Sharlin 8y agoI'm utterly unsurprised.