2 ms·

If you could log a bug here with any details that would be great! https://gitlab.com/gitlab-org/gitlab-ce https://gitlab.com/gitlab-org/gitlab-ce Thanks! Edit

If you could log a bug here with any details that would be great! https://gitlab.com/gitlab-org/gitlab-ce https://gitlab.com/gitlab-org/gitlab-ce Thanks! Edit: I wanted to clarify that if you’ve observed any undesirable behavior, we welcome you to log it and we will address it as soon as we can. I see how my original comment made it seem like we ship untested code. That’s not the case as Sid mentioned below. That being said, there might be specific edge cases or scenarios we have not captured in our tests. So problems do appear from time to time. So I wanted to invite anybody to log any problem so that we can reproduce it as soon as we can and get it fixed. Also as Sid mentioned, this feature was recently brought to Core so that more users now have access to it.

hitekker 8y ago
Please stop using your customers as your Quality Control. I get Gitlab is going for "breadth over depth", but your company must ensure the features being promoted actually work. Shipping untested code does not build confidence.
- sytse 8y ago
  We're not using our customers as quality control. Changes can be minimal but they have to meet our definition of done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#definition-of-done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU... that includes tests. I assume the relevant product manager (Victor) hasn't heard this complain before but that doesn't show from his answer. This feature was open sourced in 11.0 https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#squash-and-merge-in-gitlab-core-and-gitlabcom-free https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#sq... after many people requested it https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 but the code has been in use by users since GitLab 8.17 (Feb 22, 2017) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 so I think that is why Victor assumed this was a user specific problem.
- victorwu 8y ago
  hitekker: See my edited comment above. We do not ship untested code. But any problems that users do find we definitely want them captured as soon as possible so that we can triage and fix.

hitekker 8y ago

Please stop using your customers as your Quality Control. I get Gitlab is going for "breadth over depth", but your company must ensure the features being promoted actually work. Shipping untested code does not build confidence.

sytse 8y ago
We're not using our customers as quality control. Changes can be minimal but they have to meet our definition of done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#definition-of-done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU... that includes tests. I assume the relevant product manager (Victor) hasn't heard this complain before but that doesn't show from his answer. This feature was open sourced in 11.0 https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#squash-and-merge-in-gitlab-core-and-gitlabcom-free https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#sq... after many people requested it https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 but the code has been in use by users since GitLab 8.17 (Feb 22, 2017) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 so I think that is why Victor assumed this was a user specific problem.
victorwu 8y ago
hitekker: See my edited comment above. We do not ship untested code. But any problems that users do find we definitely want them captured as soon as possible so that we can triage and fix.