7 ms·

A month of nothing but performance tweaks and bugfixes would be great though.

by aw3c2 8y ago

ggregoire 8y ago
They introduced "squash" and "modify commit message" on the last release. It worked 1 time on the 4 times I tried.
- victorwu 8y ago
  If you could log a bug here with any details that would be great! https://gitlab.com/gitlab-org/gitlab-ce https://gitlab.com/gitlab-org/gitlab-ce Thanks! Edit: I wanted to clarify that if you’ve observed any undesirable behavior, we welcome you to log it and we will address it as soon as we can. I see how my original comment made it seem like we ship untested code. That’s not the case as Sid mentioned below. That being said, there might be specific edge cases or scenarios we have not captured in our tests. So problems do appear from time to time. So I wanted to invite anybody to log any problem so that we can reproduce it as soon as we can and get it fixed. Also as Sid mentioned, this feature was recently brought to Core so that more users now have access to it.
  - hitekker 8y ago
    Please stop using your customers as your Quality Control. I get Gitlab is going for "breadth over depth", but your company must ensure the features being promoted actually work. Shipping untested code does not build confidence.
    - sytse 8y ago
      We're not using our customers as quality control. Changes can be minimal but they have to meet our definition of done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#definition-of-done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU... that includes tests. I assume the relevant product manager (Victor) hasn't heard this complain before but that doesn't show from his answer. This feature was open sourced in 11.0 https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#squash-and-merge-in-gitlab-core-and-gitlabcom-free https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#sq... after many people requested it https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 but the code has been in use by users since GitLab 8.17 (Feb 22, 2017) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 so I think that is why Victor assumed this was a user specific problem.
    - victorwu 8y ago
      hitekker: See my edited comment above. We do not ship untested code. But any problems that users do find we definitely want them captured as soon as possible so that we can triage and fix.
- apple4ever 8y ago
  Fixing merge conflicts is completely broken for me ever since they introduced it.
sytse 8y ago
We have to balance shipping new features https://about.gitlab.com/handbook/ceo/#how-do-we-keep-shipping https://about.gitlab.com/handbook/ceo/#how-do-we-keep-shippi... with performance tweaks and bugfixes. If we would not have shipped new features and still did just just version control GitLab the company would not be viable. We're committed to shipping a single application for the whole DevOps lifecycle this year https://about.gitlab.com/2017/10/11/from-dev-to-devops/ https://about.gitlab.com/2017/10/11/from-dev-to-devops/ But there are multiple performance tweaks en bugfixes going out every month, including this one. The big performance tweak in this release is the merge request view refactor https://about.gitlab.com/2018/07/22/gitlab-11-1-released/#merge-request-comments-vuejs-refactor https://about.gitlab.com/2018/07/22/gitlab-11-1-released/#me... which makes loading merge requests much faster but there are 35 other performance improvements https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=all&utf8=%E2%9C%93&state=merged&label_name%5B%5D=performance&milestone_title=11.1 https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=... There were 141 bugs closed in this release https://gitlab.com/groups/gitlab-org/-/issues?scope=all&utf8=%E2%9C%93&state=closed&milestone_title=11.1&label_name[]=bug https://gitlab.com/groups/gitlab-org/-/issues?scope=all&utf8...
- aw3c2 8y ago
  Thank you for this nice reply (and all the great work of course)!
  - sytse 8y ago
    You're welcome! :) Thanks for caring about GitLab. New features vs. bugfixes is a hard balance and feedback helps us to find it.
    - mcny 8y ago
      Congrats on shipping! Sometimes new features appear straightforward but the implementation details can be complicated. For example, https://gitlab.com/gitlab-org/gitlab-ce/issues/18157 https://gitlab.com/gitlab-org/gitlab-ce/issues/18157 Just off the top of my head: How do you feel about CI/CD for gitlab? I mean in the sense of a publicly available unstable.gitlab.com where we warn users that everything will can get deleted at any time without notice? Maybe it is already possible?
Promarged 8y ago
Or cleaning up their work-in-progress, currently there are around 11307 issues open: https://gitlab.com/gitlab-org/gitlab-ce/issues https://gitlab.com/gitlab-org/gitlab-ce/issues
- sytse 8y ago
  Among other things we use the issue tracker for feature proposals. So it is not a good proxy of work in progress.
DanielDent 8y ago
It really really would. And it's a very good thing that their product allows you to self-host, because I have zero-confidence in their ability to properly operate infrastructure. But the attention to detail/quality on the product itself is lacking too. Don't get me wrong, I love gitlab as a product, but they really don't seem to care about working on anything that doesn't let them check another box on a marketing feature sheet. A selection of some issue I've filed... Only took around a year to fix: https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 Then this issue lingered for about a year before being closed because a customer filed a similar issue a couple months after I did... that other issue is still open though, so maybe they'll get around to it eventually: https://gitlab.com/gitlab-org/gitlab-ce/issues/25535 https://gitlab.com/gitlab-org/gitlab-ce/issues/25535 Here's one from two years ago that's still open: https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 It's possible that issue is actually fixed now. I don't know and I don't care anymore. Here another issue from 2 years ago: https://gitlab.com/gitlab-org/gitlab-ce/issues/19656 https://gitlab.com/gitlab-org/gitlab-ce/issues/19656 I filed that issue after a Gitlab person here on hacker news specifically invited feedback on UX/UI issues, and I had just spent a frustrating time trying to track down a runner. At some point I just stopped filing issues & started ignoring the issues I'd already filed. The times they decided to close issues because they'd been open a long time certainly didn't inspire me to waste any more time trying to help them improve the product. Closing & re-opening and re-tagging and doing everything but actually fixing the issue is not confidence inspiring. Gitlab is still a great product, but now when I run into things that might warrant opening an issue, I just find ways of dealing with them on my own.
- sytse 8y ago
  I wanted to give some context issue by issue. 1. We consider stopping an environment https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 a new feature, not a bug. 2. Relative submodule links are planned for 11.3 https://gitlab.com/gitlab-org/gitlab-ce/issues/37356 https://gitlab.com/gitlab-org/gitlab-ce/issues/37356 3. Not showing a retry option to logged out users https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 is a good improvement but since very few logged out users will see this message we don't consider it a bug. 4. Showing the original project next to the runner IDs makes a lot of sense. As you can see in the issue we are no longer closing feature proposals due to inactivity. If you find ways of dealing with above things on your own that involve modifying GitLab please consider contributing them back.

A month of nothing but performance tweaks and bugfixes would be great though.

by aw3c2 8y ago

A month of nothing but performance tweaks and bugfixes would be great though.

ggregoire 8y ago

They introduced "squash" and "modify commit message" on the last release. It worked 1 time on the 4 times I tried.

victorwu 8y ago
If you could log a bug here with any details that would be great! https://gitlab.com/gitlab-org/gitlab-ce https://gitlab.com/gitlab-org/gitlab-ce Thanks! Edit: I wanted to clarify that if you’ve observed any undesirable behavior, we welcome you to log it and we will address it as soon as we can. I see how my original comment made it seem like we ship untested code. That’s not the case as Sid mentioned below. That being said, there might be specific edge cases or scenarios we have not captured in our tests. So problems do appear from time to time. So I wanted to invite anybody to log any problem so that we can reproduce it as soon as we can and get it fixed. Also as Sid mentioned, this feature was recently brought to Core so that more users now have access to it.
- hitekker 8y ago
  Please stop using your customers as your Quality Control. I get Gitlab is going for "breadth over depth", but your company must ensure the features being promoted actually work. Shipping untested code does not build confidence.
  - sytse 8y ago
    We're not using our customers as quality control. Changes can be minimal but they have to meet our definition of done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#definition-of-done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU... that includes tests. I assume the relevant product manager (Victor) hasn't heard this complain before but that doesn't show from his answer. This feature was open sourced in 11.0 https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#squash-and-merge-in-gitlab-core-and-gitlabcom-free https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#sq... after many people requested it https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 but the code has been in use by users since GitLab 8.17 (Feb 22, 2017) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 so I think that is why Victor assumed this was a user specific problem.
  - victorwu 8y ago
    hitekker: See my edited comment above. We do not ship untested code. But any problems that users do find we definitely want them captured as soon as possible so that we can triage and fix.
apple4ever 8y ago
Fixing merge conflicts is completely broken for me ever since they introduced it.

sytse 8y ago

We have to balance shipping new features https://about.gitlab.com/handbook/ceo/#how-do-we-keep-shipping https://about.gitlab.com/handbook/ceo/#how-do-we-keep-shippi... with performance tweaks and bugfixes. If we would not have shipped new features and still did just just version control GitLab the company would not be viable. We're committed to shipping a single application for the whole DevOps lifecycle this year https://about.gitlab.com/2017/10/11/from-dev-to-devops/ https://about.gitlab.com/2017/10/11/from-dev-to-devops/ But there are multiple performance tweaks en bugfixes going out every month, including this one. The big performance tweak in this release is the merge request view refactor https://about.gitlab.com/2018/07/22/gitlab-11-1-released/#merge-request-comments-vuejs-refactor https://about.gitlab.com/2018/07/22/gitlab-11-1-released/#me... which makes loading merge requests much faster but there are 35 other performance improvements https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=all&utf8=%E2%9C%93&state=merged&label_name%5B%5D=performance&milestone_title=11.1 https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=... There were 141 bugs closed in this release https://gitlab.com/groups/gitlab-org/-/issues?scope=all&utf8=%E2%9C%93&state=closed&milestone_title=11.1&label_name[]=bug https://gitlab.com/groups/gitlab-org/-/issues?scope=all&utf8...

aw3c2 8y ago
Thank you for this nice reply (and all the great work of course)!
- sytse 8y ago
  You're welcome! :) Thanks for caring about GitLab. New features vs. bugfixes is a hard balance and feedback helps us to find it.
  - mcny 8y ago
    Congrats on shipping! Sometimes new features appear straightforward but the implementation details can be complicated. For example, https://gitlab.com/gitlab-org/gitlab-ce/issues/18157 https://gitlab.com/gitlab-org/gitlab-ce/issues/18157 Just off the top of my head: How do you feel about CI/CD for gitlab? I mean in the sense of a publicly available unstable.gitlab.com where we warn users that everything will can get deleted at any time without notice? Maybe it is already possible?

Promarged 8y ago

Or cleaning up their work-in-progress, currently there are around 11307 issues open: https://gitlab.com/gitlab-org/gitlab-ce/issues https://gitlab.com/gitlab-org/gitlab-ce/issues

sytse 8y ago
Among other things we use the issue tracker for feature proposals. So it is not a good proxy of work in progress.

DanielDent 8y ago

It really really would. And it's a very good thing that their product allows you to self-host, because I have zero-confidence in their ability to properly operate infrastructure. But the attention to detail/quality on the product itself is lacking too. Don't get me wrong, I love gitlab as a product, but they really don't seem to care about working on anything that doesn't let them check another box on a marketing feature sheet. A selection of some issue I've filed... Only took around a year to fix: https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 Then this issue lingered for about a year before being closed because a customer filed a similar issue a couple months after I did... that other issue is still open though, so maybe they'll get around to it eventually: https://gitlab.com/gitlab-org/gitlab-ce/issues/25535 https://gitlab.com/gitlab-org/gitlab-ce/issues/25535 Here's one from two years ago that's still open: https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 It's possible that issue is actually fixed now. I don't know and I don't care anymore. Here another issue from 2 years ago: https://gitlab.com/gitlab-org/gitlab-ce/issues/19656 https://gitlab.com/gitlab-org/gitlab-ce/issues/19656 I filed that issue after a Gitlab person here on hacker news specifically invited feedback on UX/UI issues, and I had just spent a frustrating time trying to track down a runner. At some point I just stopped filing issues & started ignoring the issues I'd already filed. The times they decided to close issues because they'd been open a long time certainly didn't inspire me to waste any more time trying to help them improve the product. Closing & re-opening and re-tagging and doing everything but actually fixing the issue is not confidence inspiring. Gitlab is still a great product, but now when I run into things that might warrant opening an issue, I just find ways of dealing with them on my own.

sytse 8y ago
I wanted to give some context issue by issue. 1. We consider stopping an environment https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 a new feature, not a bug. 2. Relative submodule links are planned for 11.3 https://gitlab.com/gitlab-org/gitlab-ce/issues/37356 https://gitlab.com/gitlab-org/gitlab-ce/issues/37356 3. Not showing a retry option to logged out users https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 is a good improvement but since very few logged out users will see this message we don't consider it a bug. 4. Showing the original project next to the runner IDs makes a lot of sense. As you can see in the issue we are no longer closing feature proposals due to inactivity. If you find ways of dealing with above things on your own that involve modifying GitLab please consider contributing them back.