2 ms·
Yes very valid points. I am thinking of making flashcards with all the styling comments and really internalise them. Its like failing a driving license test ev
by navalsaini 8y ago
Yes very valid points.
I am thinking of making flashcards with all the styling comments and really internalise them. Its like failing a driving license test everytime I create a pull request. haha...
Anyways, I was keen on knowing if this is a common problem (say like 10% of the population faces or its even scarcer).
I personally have never seen a project fail because the styling was a little off. I have seen projects succeed because they hit the customer early, and fail because they didn't do it a lot better than existing solutions. But then, to be honest, every project has its own flavours to success.
- bzalasky 8y agoForget notecards, what you need is a well configured linter. There's no reason to save style issues for code review when they can be caught with static analysis. Having encountered this team issue previously, linting made it a non-issue. Pre-commit hooks and CI are two options for enforcing code style.