4 ms·

"It requires your permission to: Access your data for all web sites" I wish Firefox had a permission along the lines of 'Access all data from pages on which I

"It requires your permission to: Access your data for all web sites" I wish Firefox had a permission along the lines of 'Access all data from pages on which I activate the extension', which is presumably all this would need.

yoklov 8y ago
It also needs data when you click on a link it created in the past, which there's no real way for it to know in advance. (It could possibly use a custom protocol but it would break backwards compatibility with HTTP which would be a big downside)
Rumperuu 8y ago
As yoklov said, I had to have a small script[1] run a quick check on every page you visit to check if the URL is a Pinpointer URL. As far as I can tell there's no way around this (and I'd say breaking backwards compatibility with HTTP is a bit drastic for a little browser extension like this). [1] https://github.com/Rumperuu/Pinpointer/blob/master/content_scripts/checkPage.js https://github.com/Rumperuu/Pinpointer/blob/master/content_s...
- ChrisSD 8y ago
  Could you not use webNavigation[0] to check the url and permissions API to ask for permission[1] if necessary? EDIT: Or tabs.onUpdated if webNavigation doesn't fire for hash changes[2] [0] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webNavigation https://developer.mozilla.org/en-US/Add-ons/WebExtensions/AP... [1] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/permissions https://developer.mozilla.org/en-US/Add-ons/WebExtensions/AP... [2] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/onUpdated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/AP...
iza 8y ago
There is the "activeTab" permission: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/permissions#activeTab_permission https://developer.mozilla.org/en-US/Add-ons/WebExtensions/ma...
- Rumperuu 8y ago
  It looks like that can only be triggered if the user interacts with the extension in some way. Presumably, then, it won't work if there's a script that should run on each page load. EDIT: I had a look at the manifest.json[1], and it turns out that's the only permission I've requested. Not sure why Firefox says I'm asking for everything and the kitchen sink. [1] https://github.com/Rumperuu/Pinpointer/blob/master/manifest.json https://github.com/Rumperuu/Pinpointer/blob/master/manifest....

yoklov 8y ago

It also needs data when you click on a link it created in the past, which there's no real way for it to know in advance. (It could possibly use a custom protocol but it would break backwards compatibility with HTTP which would be a big downside)

Rumperuu 8y ago

As yoklov said, I had to have a small script[1] run a quick check on every page you visit to check if the URL is a Pinpointer URL. As far as I can tell there's no way around this (and I'd say breaking backwards compatibility with HTTP is a bit drastic for a little browser extension like this). [1] https://github.com/Rumperuu/Pinpointer/blob/master/content_scripts/checkPage.js https://github.com/Rumperuu/Pinpointer/blob/master/content_s...

ChrisSD 8y ago
Could you not use webNavigation[0] to check the url and permissions API to ask for permission[1] if necessary? EDIT: Or tabs.onUpdated if webNavigation doesn't fire for hash changes[2] [0] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webNavigation https://developer.mozilla.org/en-US/Add-ons/WebExtensions/AP... [1] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/permissions https://developer.mozilla.org/en-US/Add-ons/WebExtensions/AP... [2] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/onUpdated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/AP...

iza 8y ago

There is the "activeTab" permission: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/permissions#activeTab_permission https://developer.mozilla.org/en-US/Add-ons/WebExtensions/ma...

Rumperuu 8y ago
It looks like that can only be triggered if the user interacts with the extension in some way. Presumably, then, it won't work if there's a script that should run on each page load. EDIT: I had a look at the manifest.json[1], and it turns out that's the only permission I've requested. Not sure why Firefox says I'm asking for everything and the kitchen sink. [1] https://github.com/Rumperuu/Pinpointer/blob/master/manifest.json https://github.com/Rumperuu/Pinpointer/blob/master/manifest....