3 ms·

Maybe start introduction with your pull requests, not destructive criticism?

• gwbas1c 8y ago
  I doubt there's been any real code reviews. If there were code reviews, they were probably treated as formalities. (Without really understanding the context,) one thing to do is just emphasize code reviews. There are many ways to do it. In 1-1s with team members, set expectations for code reviews. (Read through every change, question anything that looks odd, you're supposed to request changes.) In team meetings, pull up an open pull request and start asking questions. I've worked with a lot of people who come into my team assuming that the code review is a formality. Some team members adjust, and others leave for more sloppy assignments.