3 ms·
Reflecting on it months later, I’m more open to the rest of those changes (I was never against any of them, but I had reservations), but I’m still a bit baffled
by chrismorgan 8y ago
Reflecting on it months later, I’m more open to the rest of those changes (I was never against any of them, but I had reservations), but I’m still a bit baffled that bare `crate` as a visibility modifier, instead of `pub(crate)`, was approved. The rest has rationale, but that just doesn’t have compelling rationale (apart saying “this lets us forget about `pub(…)` syntax completely” counts), and met with quite a bit of resistance as well.
I may still end up writing it if it goes out in that form; I’m not sure. Certainly removing the need for `extern crate` reduces the probability of confusion for developers old and new after the dust settles.
- burntsushi 8y agoI think you also need to consider consistency with the fact that `crate` can be used to start paths local to the crate in Rust 2018. (I'm not bothered by these changes personally, but I'm not really bothered by the status quo either.)