3 ms·
There's nothing holding you back from setting up a process in which developers can approve their own pull requests. I worked with such a workflow before and it
by Raphmedia 8y ago
There's nothing holding you back from setting up a process in which developers can approve their own pull requests.
I worked with such a workflow before and it worked like a charm. You only ask for a third-party approval when you know the feature you worked on is big and might break something. It is all about trust.
The pull request interface is very good to show you all the code you worked on and review everything before committing to master.
- dtech 8y agoWhy require PR approval if people can do it themselves? Then it just becomes useless ceremony over allowing people to merge without approvals or PRs
- wrs 8y agoPRs are a useful artifact that can trigger CI builds, provide an organized way to discuss changes, record reasoning behind multi-commit changes, etc. etc.
- Raphmedia 8y agoBecause that way people "stamp" their work. There's no excuse, you can't lie to yourself about half done tasks. You made a PR and even approved it.