3 ms·
Fair enough, I wasn't sure if the review was just fiction - a good idea to base the article on. However, I do want to refute that English skill has anything to
by guitarbill 8y ago
Fair enough, I wasn't sure if the review was just fiction - a good idea to base the article on.
However, I do want to refute that English skill has anything to do with the things I'm pointing out. Your English is fine, plus I don't care, as I also had to learn English as a second language. The issues are purely technical.
First, `BaseException` is introduced in the refactored versions, not in the original code - so it's hardly Peter's fault. Second, the misspelling is in code, and it stops the REPL example from working ("from inpect import signature") - the REPL code looks like it's copy & pasted from the console, but it can't be.
So "suspect" was probably the wrong word to use here, even if that code has been altered. I hope you can use the feedback to improve the article, even if the feedback is worded poorly!
- mastro35 8y agoFor the BaseException you’re right. About the mispelled word I didn’t notice it... that’s weird, it IS a copy and paste, probably when I pasted it I lost that line and I rewrote it? Can’t remember, I posted the original article on Medium on December 2017. However I will surely modify the article next week to address that typo, thanks!