3 ms·

Hi guitarbill, the article is intended to point out how to review the original code. I figured out a bad code written by anyone else and I tried to make it bett

Hi guitarbill, the article is intended to point out how to review the original code. I figured out a bad code written by anyone else and I tried to make it better. About the lambdas you are right, they’re good just if you have trivial functions, like in other languages. If you need more “power” just use normal functions. PS: if I mispelled “inspect” or anything else... sorry, I’m not a native speaker, I wish I could speak and write better but the truth is that my English sucks... :(

RussianCow 8y ago
> I’m not a native speaker, I wish I could speak and write better but the truth is that my English sucks For what it's worth, I actually would never have guessed that; in fact, I think your English is better than that of many native English speakers I know. Keep at it!
guitarbill 8y ago
Fair enough, I wasn't sure if the review was just fiction - a good idea to base the article on. However, I do want to refute that English skill has anything to do with the things I'm pointing out. Your English is fine, plus I don't care, as I also had to learn English as a second language. The issues are purely technical. First, `BaseException` is introduced in the refactored versions, not in the original code - so it's hardly Peter's fault. Second, the misspelling is in code, and it stops the REPL example from working ("from inpect import signature") - the REPL code looks like it's copy & pasted from the console, but it can't be. So "suspect" was probably the wrong word to use here, even if that code has been altered. I hope you can use the feedback to improve the article, even if the feedback is worded poorly!
- mastro35 8y ago
  For the BaseException you’re right. About the mispelled word I didn’t notice it... that’s weird, it IS a copy and paste, probably when I pasted it I lost that line and I rewrote it? Can’t remember, I posted the original article on Medium on December 2017. However I will surely modify the article next week to address that typo, thanks!

RussianCow 8y ago

> I’m not a native speaker, I wish I could speak and write better but the truth is that my English sucks For what it's worth, I actually would never have guessed that; in fact, I think your English is better than that of many native English speakers I know. Keep at it!

guitarbill 8y ago

Fair enough, I wasn't sure if the review was just fiction - a good idea to base the article on. However, I do want to refute that English skill has anything to do with the things I'm pointing out. Your English is fine, plus I don't care, as I also had to learn English as a second language. The issues are purely technical. First, `BaseException` is introduced in the refactored versions, not in the original code - so it's hardly Peter's fault. Second, the misspelling is in code, and it stops the REPL example from working ("from inpect import signature") - the REPL code looks like it's copy & pasted from the console, but it can't be. So "suspect" was probably the wrong word to use here, even if that code has been altered. I hope you can use the feedback to improve the article, even if the feedback is worded poorly!

mastro35 8y ago
For the BaseException you’re right. About the mispelled word I didn’t notice it... that’s weird, it IS a copy and paste, probably when I pasted it I lost that line and I rewrote it? Can’t remember, I posted the original article on Medium on December 2017. However I will surely modify the article next week to address that typo, thanks!