3 ms·
Curious: you think it's better to crash attempting to use a NULL pointer? If so, why is that better than checking for the NULL?
by js2 16y ago
Curious: you think it's better to crash attempting to use a NULL pointer? If so, why is that better than checking for the NULL?
- tptacek 16y agoI think regimes that involve manual checking introduce the possibility of mistakes; when those mistakes involve array references, they can be exploitable. I've always, in both my dev career and in security research, felt that manual checking is dumb. In 99.999% of cases, the only option given to code when allocations fail is to start a chain of events that ends the program. Inflating each and every allocation (or, more likely, missing the little things that allocate silently, like strdup) into 4-5 lines of code seems wasteful. What I advocate is what my friend Danny told me he did at Juno in the mid '90s: preload a wrapper on malloc (don't use silly wrappers like "xmalloc") that catches faults and does something intelligent; centralize your handling of allocation failures, instead of trying to graft it onto each and every allocation point. The nice thing about my philosophy: it means that when you write normal, non-runtime code, you just pretend malloc never fails. Your code is cleaner, and it's probably safer.
- __david__ 16y agoIt depends what kind of program it is. A long running GUI program probably doesn't want to completely abort if the user tries to open file that it doesn't have enough memory to process--especially if there are other unsaved documents open. Similarly an embedded program might not want to reboot itself if there aren't enough memory resources to carry out a command (due to other commands being processed at the same time). But you are right, a lot of the time (perhaps even the majority of the time) it really is perfectly acceptable to just die if you can't malloc(). And it really does take a lot of effort to manage memory like that, but if it is done right it can really make things work robustly.
- tptacek 16y agoYour allocation failure strategy is orthogonal to how individual allocations should be handled. In a UI program, keep a reserve of memory, return valid addresses to the caller, and pop up a warning. It's actually easier to do things like this if you aren't hand-crafting individual little alloc-check-handle routines.
- __david__ 16y agoThat seems full of edge cases. If your reserve isn't big enough it doesn't help and if it's too big then it's a waste. It seems much cleaner to be able to gracefully abort whatever operation you were doing. Presumably there is already error handling for fs/network errors. Usually you can hop onto those handlers with memory errors and be just fine. Though if it's linux it'll just kill you anyway :-). (Yeah, I know you can turn the OOM killer off).