3 ms·
> Every idea is one commit Ideally, a commit should be self contained and change only one thing. This means that a feature would consist of multiple commits.
by u801e 8y ago
> Every idea is one commit
Ideally, a commit should be self contained and change only one thing. This means that a feature would consist of multiple commits.
Since later commits may depend one or more earlier commits (some of which may be in the same feature branch), how do tools that work on a commit based workflow handle those dependencies?
- drewg123 8y agoDependent changes are a nightmare in phabricator. I tried it once using arcanist and git, and it seemed to be confused about which patchset I wanted to change. After this experience, I talked to a few colleagues, and they basically said "yeah, just don't use dependent reviews"
- lima 8y agoMost large teams avoid long-lived feature branches and instead try to get things reviewed and merged into master as soon as possible. It's better to have many small reviews than a few massive ones. You usually try to avoid dependencies. If you can't avoid them, have a series of patches depend on each other. Phabricator supports stacking patches. Here's a random patchset: https://secure.phabricator.com/D19429 https://secure.phabricator.com/D19429 Scroll down to "Stack" - it will display the list of patches depending on each other: https://i.imgur.com/WTl4B8x.png https://i.imgur.com/WTl4B8x.png