3 ms·
1. Where should this if statement live? 2. Your solution assumes the full shipping address is known to where you think this code should live. 3. No edge cases
by consciouskernel 8y ago
1. Where should this if statement live?
2. Your solution assumes the full shipping address is known to where you think this code should live.
3. No edge cases are being handled here.
4. What's the additional server burden for your solution? Do we need to provision additional capacity? What about DB capacity?
5. What does pay_gst actually do? Is it handling only charging an additional price? What about accounting, tax, and reporting?
6. Why are we evading sales tax in the else? We might still need to collect other sales taxes. Amazon.com is also the primary portal for NA, so it still needs to collect local/state taxes.
7. How should we handle updating the DB tables? What about the derived tables?
I could easily go on.