4 ms·
This seems like a cool idea, but I'm hesitant to run it locally. Is an early version of the application with no unit tests and it eagerly calls `sh` command wi
by _Marak_ 8y ago
This seems like a cool idea, but I'm hesitant to run it locally.
Is an early version of the application with no unit tests and it eagerly calls `sh` command with string input ( see: https://github.com/egoist/maid/blob/master/lib/index.js https://github.com/egoist/maid/blob/master/lib/index.js )
I would be worried that some parse error or non-obvious typo in the Markdown format could result in `sh` accidentally running something destructive locally.
Still though, I like the idea and am now following the project, you should keep working on it!
You may want to consider running the Node tasks in a separate subprocess instead of using `require-from-string` module in parent process. You could also try using https://github.com/stackvana/microcule https://github.com/stackvana/microcule to add support for subprocess execution and multiple programming languages.
- 0x142857 8y agoyeah unit tests are coming.. > I would be worried that some parse error or non-obvious typo in the Markdown format well I couldn't help this too much since it uses markdown-it under the hood to parse the markdown, i think it's safe as long as you don't write destructive shell script yourself.. > You may want to consider running the Node tasks in a separate subprocess instead of using `require-from-string` module in parent process. will give this a try. also PR welcome xD
- _Marak_ 8y agoThat sounds good! I'll keep an eye on the Github Issues and may make a PR.
- andrew_ 8y ago`require-from-string` also presents all kinds of problems with regard to the require cache. Notably, cosmiconfig recently dropped use of that module.