4 ms·
They don't collect command line arguments according to the github issue.
by philliphaydon 8y ago
They don't collect command line arguments according to the github issue.
- 0x0 8y agoThey do collect at least the first argument, how else do they end up with "bulid"? Accidents happen and someone could paste or tab-complete a confidential thing in that spot...
- dingo_bat 8y agoSo if you push your api key to github by accident is github responsible?
- 0x0 8y agoInvalid comparison, in my humble opinion. Pushing a secret API key to github, even accidentally, does not happen covertly or as an unexpected side effect of some other tool written by github, and you'll soon realize what happens because you'll see your key sitting there. You also have a general idea of what you are playing with when you start using github, whether it's private repos or public repos. Having a local CLI tool submit your secret API key as part of telemetry collecting command line arguments is totally unexpected and invisible for the user, and you won't even see it has happened.
- philliphaydon 8y agoI Guess they whitelist it. If someone types a valid command send the command. If someone types an invalid command then it prob sends something that isn’t descriptive. (Assumptions I’m making)
- opencl 8y agoAccording to this PR they do collect command line arguments. https://github.com/dotnet/cli/pull/2145 https://github.com/dotnet/cli/pull/2145 "My understanding is that this was recently discussed with our privacy team and we concluded that collecting the arguments themselves (hashed or not) is not acceptable per our privacy policies. Not sure whether the code already reflects that, but it's being worked on." Somebody in the thread for the issue said it's "not acceptable per our privacy policies" and "being worked on" two years ago, but did they ever actually stop collecting command line arguments?