3 ms·
You should follow the project's style when you start contributing. If style is pointed out in code review, fix it.
by sanxiyn 8y ago
You should follow the project's style when you start contributing. If style is pointed out in code review, fix it.
- guitarbill 8y agoWell yes, I agree. It's a bit of a toy example, simplistic, but hopefully one we can all relate to. It does illustrate the issue of using "meritocracy" without anything else. It's like saying "we follow a style guide", and then not providing that style guide. Obviously sub-optimal. (The example breaks down since providing a style guide is doable, whereas providing a "merit guide" is hard/impossible? In that case, is it better to remove that? I don't know.)