4 ms·

What a lovely comment, explaining not just the why but also, in this case, the 'how' because its not obvious how to derive the code from the requirement so actu

What a lovely comment, explaining not just the why but also, in this case, the 'how' because its not obvious how to derive the code from the requirement so actually explaining how is worth it. But then I scrolled down and saw it verbatim just a few lines further down https://github.com/behdad/cairo/blob/color-emoji/src/cairo-path-stroke-polygon.c#L603 https://github.com/behdad/cairo/blob/color-emoji/src/cairo-p... Why is CheckMitreHight() not a function? :)

aidos 8y ago
And a bunch of other places in the codebase from memory (cairo-path-stroke.c, cairo-path-stroke-polygon.c and cairo-path-stroke-tristrip.c). And there's a bug in there too because they're working in the wrong space so the checks are applied after outer transformations [0].... but it's still a great comment! :-) [0] https://bugs.freedesktop.org/show_bug.cgi?id=100703 https://bugs.freedesktop.org/show_bug.cgi?id=100703